chore(repo): correct READMEs, minimatch to picomatch #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
requested review from
tjenkinson,
Andarist and
shellscape
as code owners
Andarist
approved these changes
Sep 8, 2022
shellscape
changed the title
|
Verified the failing test is passing locally, so merging this as-is. |
Jesuis33
pushed a commit
to Jesuis33/ReinhardOosthuizen
that referenced
this pull request
Sep 19, 2022
* fix(babel): correct minimatch to picomatch * fix(buble): correct minimatch to picomatch * fix(commonjs): correct minimatch to picomatch * fix(dsv): correct minimatch to picomatch * fix(dynamic-import): correct minimatch to picomatch * docs(graphql): correct minimatch to picomatch * fix(image): correct minimatch to picomatch * fix(inject): correct minimatch to picomatch * fix(replace): correct minimatch to picomatch * fix(strip): correct minimatch to picomatch * fix(sucrase): correct minimatch to picomatch * docs(typescript): correct minimatch to picomatch * fix(url): correct minimatch to picomatch * fix(yaml): correct minimatch to picomatch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
babel,buble,commonjs,dsv,dynamic-import-vars,graphql,image,inject,replace,strip,sucrase,typescript,url,yamlThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
createFilterfunc from@rollup/pluginutils<=v3.0.10 uses picomatch and >v3.0.10 usesminimatch(#306).picomatchsupports slightly different features fromminimatch. https://github.com/rollup/plugins/tree/master/packages/pluginutils#include-and-excludeSo I updated documents/dts from "minimatch pattern" to "picomatch pattern".
This is the list that shows which plugin uses which version of
@rollup/pluginutils:@rollup/plugin-babel: ^3.1.0@rollup/plugin-buble: ^3.1.0@rollup/plugin-commonjs: ^3.1.0@rollup/plugin-dsv: ^3.1.0@rollup/plugin-dynamic-import-vars: ^4.1.2@rollup/plugin-graphql: ^4.0.0@rollup/plugin-image: ^3.1.0@rollup/plugin-inject: ^3.1.0@rollup/plugin-replace: ^3.1.0@rollup/plugin-strip: ^3.1.0@rollup/plugin-sucrase: ^4.1.1@rollup/plugin-typescript: ^3.1.0@rollup/plugin-url: ^4.2.1@rollup/plugin-yaml: ^3.1.0I didn't change:
@rollup/plugin-json: because it uses@rollup/pluginutils^3.0.8, so eitherminimatchorpicomatchmight be used@rollup/plugin-multi-entry: because it usesmatched